Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there are no parameter labels on radio or range elements in the browser #6

Closed
landlessness opened this issue Oct 8, 2014 · 5 comments
Labels

Comments

@landlessness
Copy link
Contributor

In the screenshot below, the radio button is for a parameter labelled 'voice' and the range is for a parameter labelled 'rate'.

screen shot 2014-10-08 at 6 27 04 pm

@AdamMagaluk
Copy link
Contributor

@landlessness For range when you refer to "no parameter labels" are you referencing min, max, and step that can be specified on the <input> tag?

@AdamMagaluk
Copy link
Contributor

If I understand you correctly the range issue should be fixed in #13. Zetta allows you to specify max, min, and step when defining the input fields.

@landlessness
Copy link
Contributor Author

[You can easily recreate my experience by running the example server in this driver https://github.com/landlessness/zetta-text-to-speech-osx-driver on a mac and pointing the Zetta browser at it. There are no external dependencies.]

In the case of the screenshot above (and the code below) the text input should be labeled words, the radio group should be labeled voice and the range should be labeled rate.

Also, where would the title attributes appear?

  .map('say', this.say, [
    { name: 'words', title: 'Words to Speak', type: 'text'},
    { name: 'voice', title: 'Voice Persona', type: 'radio',
      value: this._availableVoices},
    { name: 'rate', title: 'Rate of Speech', type: 'range',
      min: 90, max: 720, step: 1, units: 'words per minute'}

@13protons 13protons self-assigned this Oct 14, 2014
@13protons
Copy link
Contributor

@landlessness @AdamMagaluk This looks like a UI issue. I'll dig into it.

@13protons
Copy link
Contributor

fixed by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants