Provision Should Return Existing Device

[wooliet]

The "good" path for Scout.prototype.provision returns the device instance. However, if the instance already exists, the result is null.

Is there a good reason for that? Feels weird to assume "success" if result is null or a returned device instance.

  // if already initiated on runtime do not create a second instnace
  if(this.server._jsDevices[deviceObject.id]) {
    return null;
  }

I'm asking because I'm in a situation where it looks like I have a false result (don't know for sure if null though) and so reach into _jsDevices for the device instance, and that is also falsey.

dev = self.provision(serverQueryResult, device, parameters);
if(!dev) {
  dev = self.server._jsDevices[result.id];
}
...
if(dev) {
 // success
} else {
  // CODE REACHES HERE
}