Threshold for losses different than original FCGF

[theycallmefm]

Hi, you state that you keep the FCGF parameters the same as in the original paper. In your code positive and negative thresholds for contrastive_hardest_negative_loss are like this.

3D_multiview_reg/lib/loss.py

Line 38 in 22468ad

# For FCGF loss we keep the parameters the same as in the original paper

self.pos_thresh = 1.4
self.neg_thresh = 0.1

However in original FCGF code default threshold parameters are opposite. https://github.com/chrischoy/FCGF/blob/f0863a9ba4a29f677c0ddd2248cf4e56b9318add/config.py#L34

trainer_arg.add_argument('--neg_thresh', type=float, default=1.4)
trainer_arg.add_argument('--pos_thresh', type=float, default=0.1)

Did you use your parameters to train FCGF descriptor? If it is a design choice could you elaborate more?

Thank you!