chore/refactor to projectmatrix #1466
Conversation
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
2 times, most recently
from
f6b944c to
b5c4abc
Compare
|
I reverted the zio-sbt-website version. As the new version added a |
examples/src/main/scala/zio/config/examples/autoderivation/AutoDerivationPureConfig.scala
Outdated
Show resolved
Hide resolved
| @@ -42,7 +42,7 @@ object AutomaticConfig extends App { | |||
| "aws.credentials.Token.value" -> "token", | |||
| "port" -> "10", | |||
| "default" -> "12", | |||
| "dburl" -> "some url", | |||
| "dburl.value" -> "some url", | |||
There was a problem hiding this comment.
There is some inconsistency on the usage of value-classes. Sometimes AnyVal is extended, sometimes not. In some tests it expects the path to have the nested path, but in this code it did not.
I think also some apps were not working in in the main branch. This change for now makes it work.
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
2 times, most recently
from
9b11812 to
dc0f710
Compare
project/plugins.sbt
Outdated
| addSbtPlugin("pl.project13.scala" % "sbt-jcstress" % "0.2.0") | ||
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.7") | ||
| addSbtPlugin("dev.zio" % "zio-sbt-website" % "0.3.1") | ||
| addSbtPlugin("com.eed3si9n" % "sbt-projectmatrix" % "0.10.0") |
There was a problem hiding this comment.
I am not sure about this. I don't think any other zio project is using this so far. And we have zio-sbt to help us with the builds. I'd prefer to stick to the same solution, unless you can make a compelling argument.
There was a problem hiding this comment.
This sbt-projectmatrix makes the build much nicer to work with imo. It is more explicit and helps to discover what platforms and versions are in scope. I have seen multiple public projects already using it and I am using it in all of my customer projects. It make it much easier to crossbuild, export all in a single bloopInstall instead of just one Scala version.
There was a problem hiding this comment.
To my understanding it should also be a default feature in SBT 2.x
There was a problem hiding this comment.
With the existing build and the command aliases to target the different platforms and scala versions it was quite error prone to make sure all projects were included. Now you do not have to use the + or ++ anymore. All projects have a direct projectref in the build.
There was a problem hiding this comment.
I think the build is much more concise now and it is targeting all the platforms and Scala versions it can support (the existing build was missing some).
There was a problem hiding this comment.
ref sbt-projectmatrix insource in sbt 2.x: https://eed3si9n.com/sbt-2.0.0-beta
project/plugins.sbt
Outdated
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.4") | ||
| addSbtPlugin("dev.zio" % "zio-sbt-website" % "0.3.1") | ||
|
|
||
| libraryDependencies += "org.snakeyaml" % "snakeyaml-engine" % "2.6" |
There was a problem hiding this comment.
was unused? or is now a transitive dependency?
There was a problem hiding this comment.
It was used to extract Scale versions from the ci.yml definition. There is quite some difference on how different zio-projects are being configured. The BuildHelper.scala has a lot if different implementations. I think the Scala versions should just be part of the build files and not extracted from ci.yml. Most projects do this and it prevent us from requiring this dependency in the sbt tasks.
ThijsBroersen
changed the title
ThijsBroersen
changed the title
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
2 times, most recently
from
b0a9848 to
325fd63
Compare
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
from
325fd63 to
efae03a
Compare
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
from
6ef6b67 to
b6c8f2b
Compare
ThijsBroersen
force-pushed
the
chore/build/refactor-to-projectmatrix-and-bump-all
branch
from
b5732c1 to
4cd168e
Compare
PR to update about all...
Build has been migrated to sbt-projectmatrix because the existing build had quite some issues and did target all platforms and versions correctly.
I also noticed some gaps. Like annotations not implemented for Scala 3.
The JDK version is updated to 17 setting the jvm release target to 11.
Fixes/enables scalafix on CI (which is enabled by default with zio-sbt-ci)