[#323] added Files.createTemp* Managed methods; added Files.deleteRec… #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vitaliihonta
force-pushed
the
feature/323
branch
from
31064ba to
6ea8686
Compare
vitaliihonta
commented
Mar 19, 2021
| @@ -106,6 +133,9 @@ object Files { | |||
| def deleteIfExists(path: Path): ZIO[Blocking, IOException, Boolean] = | |||
| effectBlocking(JFiles.deleteIfExists(path.javaPath)).refineToOrDie[IOException] | |||
|
|
|||
| def deleteRecursive(path: Path): ZIO[Blocking, IOException, Long] = | |||
There was a problem hiding this comment.
IMO this method may be useful independently of the rest updates
vitaliihonta
commented
Mar 19, 2021
| prefix: Option[String], | ||
| fileAttributes: Iterable[FileAttribute[_]] | ||
| ): ZManaged[Blocking, IOException, Path] = | ||
| ZManaged.make(createTempDirectory(prefix, fileAttributes))(release = deleteRecursive(_).ignore) |
There was a problem hiding this comment.
Not 100% sure about recursive directory deletion. But it seems to be reasonable in terms of temporary directories
vitaliihonta
commented
Mar 19, 2021
| prefix: Option[String], | ||
| fileAttributes: Iterable[FileAttribute[_]] | ||
| ): ZManaged[Blocking, IOException, Path] = | ||
| ZManaged.make(createTempFile(suffix, prefix, fileAttributes))(release = deleteIfExists(_).ignore) |
There was a problem hiding this comment.
Not sure what exactly should be used in the finalization block: ignore or orDie?
In most cases, it won't fail so I choose to ignore
There was a problem hiding this comment.
Yeah I'm not 100% sure either, but ignore seems good.
quelgar
reviewed
Mar 27, 2021
| @@ -74,6 +81,13 @@ object Files { | |||
| effectBlocking(Path.fromJava(JFiles.createTempFile(prefix.orNull, suffix, fileAttributes.toSeq: _*))) | |||
| .refineToOrDie[IOException] | |||
|
|
|||
| def createTempFileManaged( | |||
| suffix: String = ".tmp", | |||
| prefix: Option[String], | |||
There was a problem hiding this comment.
Should be fine to have prefix default to None and fileAttributes to default to Iterable.empty?
| import zio.test._ | ||
| import zio.test.Assertion._ | ||
|
|
||
| object FilesSpec extends BaseSpec { |
svroonland
pushed a commit
that referenced
this pull request
Aug 9, 2021
#327) * [#323] added Files.createTemp* Managed methods; added Files.deleteRecursive method * [#323] added default arguments to createTempFileManaged Co-authored-by: Vitalii Honta <[email protected]> Co-authored-by: Lachlan O'Dea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.