This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
Disable time features
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Plecra we need your opinion here. |
Plecra
suggested changes
Jan 30, 2023
|
Hmm, I'm not sure about standard ways to to this, but I can pop a |
Plecra
approved these changes
Jan 30, 2023
|
Oops! We've got a bug in the fuzz CI. You'll need to add |
|
(That's https://docs.rs/time/latest/time/struct.OffsetDateTime.html#method.now_utc btw - it mentions the feature dep) |
lnicola
force-pushed
the
time-features
branch
from
37a814b
to
04de44c
Compare
|
Done, can you try again? The clippy failures are unrelated. I can file a PR to fix them tomorrow, if you want. |
|
We need it for release |
lnicola
force-pushed
the
time-features
branch
from
04de44c
to
94b183b
Compare
|
Ah, okay. Fixed. |
|
Thanks! No pressure, but do you think you'll cut out a new release soon? |
|
Just after addressing the CVE issue, yep! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left these enabled in
dev-dependencies, so that the tests still work, but to be honest, I don't think those tests are really useful.The reason to disable this is the proc macro stuff has a significant build time impact, and it's not really something
zipusers need.