Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we upgrade http to https in url-constructor-detection.js ? #1345

Closed
wChenonly opened this issue May 29, 2024 · 1 comment · Fixed by #1346
Closed

Can we upgrade http to https in url-constructor-detection.js ? #1345

wChenonly opened this issue May 29, 2024 · 1 comment · Fixed by #1346

Comments

@wChenonly
Copy link
Contributor

wChenonly commented May 29, 2024

var url = new URL('b?a=1&b=2&c=3', 'http://a');

Because core.js, as a dependency of many underlying compilation packages, will appear in chunk-vendors after packaging, but some projects cannot require http, so the packaged code scan will scan out http in url-constructor-detection.js.

http://a
http://a/c%20d?a=1&c=3
...

@zloirock
Copy link
Owner

I don't think that it's good to report this case in such scanners, however, OK, it's not a big deal, so I'll replace http -> https here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants