Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hold tap: tap behavior triggers to fast for Ubuntu with modifiers #1534

Closed
tyalie opened this issue Nov 11, 2022 · 1 comment
Closed

hold tap: tap behavior triggers to fast for Ubuntu with modifiers #1534

tyalie opened this issue Nov 11, 2022 · 1 comment

Comments

@tyalie
Copy link

tyalie commented Nov 11, 2022

When using any of the hold tap behaviours and having the tap behaviour be combined with a modifier, Ubuntu will struggle to register the latter.

The issue seems to be that Ubuntu (using libinput and wayland) struggles or maybe even on purpose ignores the modifier key if it was pressed for a too short amount of time. ZMK hits that limit when using a tap in tap-hold behaviour as it can result in a difference of 1ms between press and release as shown by evtest.

Event: time 1668188704.385420, type 4 (EV_MSC), code 4 (MSC_SCAN), value 700e5
Event: time 1668188704.385420, type 1 (EV_KEY), code 54 (KEY_RIGHTSHIFT), value 1
Event: time 1668188704.385420, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70006
Event: time 1668188704.385420, type 1 (EV_KEY), code 46 (KEY_C), value 1
Event: time 1668188704.385420, -------------- SYN_REPORT ------------
Event: time 1668188704.386408, type 4 (EV_MSC), code 4 (MSC_SCAN), value 700e5
Event: time 1668188704.386408, type 1 (EV_KEY), code 54 (KEY_RIGHTSHIFT), value 0
Event: time 1668188704.386408, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70006
Event: time 1668188704.386408, type 1 (EV_KEY), code 46 (KEY_C), value 0
Event: time 1668188704.386408, -------------- SYN_REPORT ------------

I've added a 20ms delay behavior_hold_tap.c:release_binding to circumvent this and it works flawlessly. Normal human tapping behaviour seems to be around 50ms, maybe ZMK should orient along that line.

@caksoylar
Copy link
Contributor

For posterity, this seems to be a duplicate of #759 since it has become clear that Gnome with Wayland has this issue which should be fixed by Gnome 45 release.

@caksoylar caksoylar closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants