RIS: Disambiguate journal abbreviation and pub title based on length #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam3smith
reviewed
Nov 25, 2024
RIS.js
Outdated
| @@ -1764,8 +1770,18 @@ function completeItem(item) { | |||
| if (cleanDOI) item.DOI = cleanDOI; | |||
| } | |||
|
|
|||
| // hack for sites like Nature, which only use JA, journal abbreviation | |||
| if (item.journalAbbreviation && !item.publicationTitle) { | |||
| // Use the shorter journal abbreviation, and move the longer one to | |||
There was a problem hiding this comment.
You're not worried that the logic here is getting a bit convoluted? It obviously works for the issue at hand, but it's hard to keep track of what's going on in the code, which will make future troubleshooting harder.
Otherwise this looks fine.
There was a problem hiding this comment.
Good point - how about now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3394