Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for realtime camera image? ROS Integration #17

Open
DavidYaonanZhu opened this issue Jun 30, 2023 · 5 comments
Open

Support for realtime camera image? ROS Integration #17

DavidYaonanZhu opened this issue Jun 30, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@DavidYaonanZhu
Copy link

Hi,

Thanks for this amazing work.

I wonder, wether you provide support for tutorials about how to integrate with robot cameras in real-time.
Just like the example you showed by using the HSR robot.

I could also contribute to this matter.

@zubair-irshad
Copy link
Owner

Hi @DavidYaonanZhu, Please feel free to open up a PR as we don't have support for this currently. For HSR robot, apologies if we didn't mention this, but the demo was done offline i.e. first we collected rgb-d image from HSR robot and then ran our model on it. One could use ROS to stream rgb-d images and could run it online.

I found this other implementation which ran CenterSnap (our previous work) on an OAK-D and RealSense cameras. One thing worth noting here is that you might need model finetuning on cameras other than the one NOCS captured its real images from. We tried finding that camera but couldn't find it on the market. We made one minor adjustment, we warped the images from HSR robot slightly to make its intrinsics similar to the NOCS Real camera intrinsics before feeding it to ShAPO model for inference. Hope it helps!

@DavidYaonanZhu DavidYaonanZhu changed the title Support for realtime camera image? Support for realtime camera image? ROS Integration Jun 30, 2023
@DavidYaonanZhu
Copy link
Author

Thanks a lot for your answer and suggestion.

Let me try this.

@DavidYaonanZhu
Copy link
Author

DavidYaonanZhu commented Jul 3, 2023

Hi @zubair-irshad

May I ask which intrinsic parameters from the HSR camera that you adjusted to make it looks like the NOCS Real camera?

@zubair-irshad
Copy link
Owner

zubair-irshad commented Jul 4, 2023

I don't think those intrinsics matter so long as you warp the image coming out of your custom camera to match the image with NOCS real camera intrinsics. Here is a small gist I wrote that might help you. reproject function is important here and we feed the output RGB depth coming out of this function to our model in the demo results. I will update this with FAQ in the Reamde for now. Hope it helps and feel free to open up a PR if this works or you find an elegant solution. The best solution as I wrote above is to finetune the model on custom data but this works too.

@zubair-irshad zubair-irshad added the good first issue Good for newcomers label Jul 4, 2023
@DavidYaonanZhu
Copy link
Author

@zubair-irshad

Ok, thanks!
Let me try this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants