Hero animation for images should run only to/from lightbox, not between message lists #930
Assignees
Labels
a-lightbox
The lightbox / image-viewer screen
a-msglist
The message-list screen, except what's label:a-content
help wanted
Milestone
Comments
gnprice
added
a-msglist
|
i want to work on this issue , please assign this to me. |
|
can try to resolve this issue |
Adityakk9031
added a commit
to Adityakk9031/zulip-flutter
that referenced
this issue
Dec 5, 2024
resolve the hero animation
|
Please take a look at the Zulip project's guide to getting involved with the code: https://zulip.readthedocs.io/en/latest/contributing/contributing.html#your-first-codebase-contribution |
sher999
added a commit
to sher999/zulip-flutter
that referenced
this issue
Dec 13, 2024
… the LightBoxHeroTag and adding narrow on lightbox_test and content_test
sher999
added a commit
to sher999/zulip-flutter
that referenced
this issue
Dec 13, 2024
… the LightBoxHeroTag
sher999
added a commit
to sher999/zulip-flutter
that referenced
this issue
Dec 26, 2024
… the LightBoxHeroTag
|
Please assign this issue to me, I have started working on this. Created a draft PR as well need to add tests. Implementation VideoBeforeWhatsApp.Video.2025-02-12.at.5.18.39.PM.mp4AfterWhatsApp.Video.2025-02-12.at.5.18.35.PM.mp4 |
|
PR #1348 is ready for review. PTAL, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a message has an image and you tap the image to see it in the lightbox, we use a
Herowidget to cause the image to animate from its old position and size in the message list to its new position and size in the lightbox, and to do the same in reverse when you navigate back.Currently, though, our implementation of this causes those "hero" animations to happen also when you navigate from one message list to another that happens to contain the same image-bearing message. That doesn't make so much sense, and tends to look glitchy. It can look extra glitchy when the message is off screen either before or after the navigation (or even both), as spotted by @alexmv:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/Images.20have.20the.20wrong.20z-index/near/1932012
So we should fix that.
I think the way to implement this will be to augment the
tagparameter we pass toHeroso that it identifies not only the message and the image within the message, but the message list the message is shown in.The text was updated successfully, but these errors were encountered: