Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interactive sounds for better game UX #145

Merged
merged 4 commits into from
Oct 29, 2023

Conversation

SoumyadevSaha
Copy link
Contributor

Fixes Issue🛠️

Closes #138

Description👨‍💻

Applied Changes

  1. Added game BGM : Added 2 game BGMs, one for when the user is playing the game, and another when they are selecting from the menu. (both bgms are in loop, i.e, if reaches end of file, starts from beginning)
  2. Added GameOver music : Added a gameOver music, which is played when the game gets over.
  3. Smooth transition between music(s): When it is gameOver/pause/reload/back to menu/back to game events, the game logic[main.js] is updated such that the transition between 2 musics are handled smoothly.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested on local machine, after the changes were made. All plays out smoothly.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for click-the-edible-game ready!

Name Link
🔨 Latest commit c6fdf6e
🔍 Latest deploy log https://app.netlify.com/sites/click-the-edible-game/deploys/653e3e440a16cb0008453dbb
😎 Deploy Preview https://deploy-preview-145--click-the-edible-game.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Pls delete every .DS_Store files @SoumyadevSaha

@SoumyadevSaha
Copy link
Contributor Author

Pls delete every .DS_Store files @SoumyadevSaha

Deleted the .DS_Store files

@Rakesh9100
Copy link
Owner

Amazing work, Really liked the sounds !! Merged @SoumyadevSaha 🎉🥳

@Rakesh9100
Copy link
Owner

give @SoumyadevSaha 150 points

@SoumyadevSaha
Copy link
Contributor Author

Amazing work, Really liked the sounds !! Merged @SoumyadevSaha 🎉🥳

Thankyou so much 😁

@Rakesh9100 Rakesh9100 merged commit 569d822 into Rakesh9100:main Oct 29, 2023
3 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion slop3.0 SLoP 3.0 Open Source Program labels Oct 29, 2023
@SoumyadevSaha SoumyadevSaha changed the title feat : Added interactive sounds for better game UX feat: Added interactive sounds for better game UX Oct 29, 2023
@Rakesh9100 Rakesh9100 changed the title feat: Added interactive sounds for better game UX Added interactive sounds for better game UX Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion slop3.0 SLoP 3.0 Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new sound effects for better UX
2 participants