Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): removed challenge_completion_time from blobber terms #57

Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix(config): removed challenge_completion_time from blobber terms #57

merged 1 commit into from
Jun 17, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jun 16, 2022 •
edited
Loading

Changes

Fixes

  • remove cct from blobber terms

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Jun 16, 2022
Merged
Merged
Merged
Merged
Merged
@cnlangzi cnlangzi mentioned this pull request Jun 16, 2022
Merged
3 tasks
peterlimg
peterlimg approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Kishan-Dhakan
Kishan-Dhakan approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kishan-Dhakan Kishan-Dhakan merged commit 819a41b into master Jun 17, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the fix/remove_cct_from_terms branch June 17, 2022 23:03
@Kishan-Dhakan Kishan-Dhakan restored the fix/remove_cct_from_terms branch June 17, 2022 23:03
Kishan-Dhakan added a commit that referenced this pull request Jun 17, 2022
@Kishan-Dhakan
Revert "fix(config): removed challenge_completion_time from blobber t…
83d6630 
…erms (#57)"

This reverts commit 819a41b.
@Kishan-Dhakan Kishan-Dhakan mentioned this pull request Jun 17, 2022
Merged
Kishan-Dhakan added a commit that referenced this pull request Jun 17, 2022
@Kishan-Dhakan
Revert "fix(config): removed challenge_completion_time from blobber t…
a73653d 
…erms (#57)" (#58)

This reverts commit 819a41b.
@cnlangzi cnlangzi deleted the fix/remove_cct_from_terms branch June 20, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@stewartie4 stewartie4 Awaiting requested review from stewartie4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnlangzi @Kishan-Dhakan @peterlimg