Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(writemarker): add new fields on wm #444

Merged
merged 1 commit into from
Apr 26, 2022
Merged

feat(writemarker): add new fields on wm #444

merged 1 commit into from
Apr 26, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Apr 26, 2022 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi requested a review from peterlimg April 26, 2022 10:46
This was referenced Apr 26, 2022
Merged
Merged
Merged
@cnlangzi cnlangzi requested a review from dabasov April 26, 2022 10:50
dabasov
dabasov approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit dd86e26 into staging Apr 26, 2022
@cnlangzi cnlangzi deleted the feat/new_fields_on_wm branch April 26, 2022 11:46
This was referenced Apr 26, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnlangzi @dabasov