Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up collaborator feature #713

Merged
merged 4 commits into from
Feb 15, 2023
Merged

clean up collaborator feature #713

merged 4 commits into from
Feb 15, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Jan 11, 2023

Changes

  • cleanup collaborator features

Fixes 0chain/0chain#2010

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boddumanohar please update zboxcli and zwalletcli to pass the system tests

@cnlangzi cnlangzi self-requested a review as a code owner January 17, 2023 09:57
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests cleanup-collab
gosdk clean-collab
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests cleanup-collab
gosdk clean-collab
zboxcli clean-collab
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests cleanup-collab
gosdk clean-collab
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests cleanup-collab
gosdk clean-collab
zboxcli clean-collab
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk clean-collab
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit 91a06d3 into staging Feb 15, 2023
@peterlimg peterlimg deleted the clean-collab branch February 15, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup collaborator feature
3 participants