fix(zcncore): added MakeSCRestAPICall and fixed fast confirmation on GetInfo

[cnlangzi]

Changes

Fixes

• speed up get info from sharders

Tests

Tasks to complete before merging PR:

• Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

• fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… zboxcli#342
• fix(zcncore): used zcncore.MakeSCRestAPICall zwalletcli#207
• fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.MakeSCRestAPICall system_test#514

[peterlimg]

lgtm

[peterlimg]

Please fix the macos build error

[peterlimg]

For the FromConsensus, we actually don't have to do another process logic, we can do it in simliar way as the FromAll, but only send requests to part of the sharders, and collect the failed requets number as I suggested before.

[cnlangzi]

For the FromConsensus, we actually don't have to do another process logic, we can do it in simliar way as the FromAll, but only send requests to part of the sharders, and collect the failed requets number as I suggested before.

the request with be cancelled by WithTimeout if the sharder is offline or slow. and next sharder will be pushed to next channel to fix minimal online sharders. success and sent are count instead of collect failed requests number. do you think it is ok?

[peterlimg]

The first version of this PR is actually 90 percent ready, we only need to limit the request size in MakeSCRestAPICall and check the failed count, let's not overcomplicate it.

[peterlimg]

The main changes we need is in this MakeSCRestAPICall function, that we limit the shaders number instead of passing all sharders to NewTransactionQuery. Then call the FromAll() to send requests to those selected sharders. We don't need the fromConsensus.

reqSharders := util.Shuffle(copyOf(_config.chain.Sharders))[:reqNum] // util.Shuffle(_config.chain.Sharders) // this shuffle will change the Sharders slice, it's not thread safe. 
tq, err := NewTransactionQuery(reqSharders)
...

[service-0chain]

Manual system tests [cancelled] with the following config

config	value
tests skipped	FALSE
system-tests	fix/speed_up_txn_confirm
gosdk	fix/speed_up_txn_confirm
zboxcli	fix/speed_up_txn_confirm
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	fix/speed_up_txn_confirm
gosdk	fix/speed_up_txn_confirm
zboxcli	fix/speed_up_txn_confirm
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[peterlimg]

LGTM.

@cnlangzi can you create an issue for the refactoring I mentioned below, thanks.

[cnlangzi]

@peterlimg please also check https://0chain.slack.com/archives/D02FLSUG42C/p1674110680380779?thread_ts=1673955258.028839&cid=D02FLSUG42C. I left a question about consensus checking

rate := consensus * 100 / float32(len(sharders))
						if rate >= consensusThresh {
							return nonce, winInfo, nil
						}

[boddumanohar]

LGTM