-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the rounding off logic in Balance class #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a574d53
to
4404f4d
Compare
Manual system tests [failure] with the following config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manual system tests [success] with the following config
|
Improve the rounding off logic in Balance class (for changes in 0chain/gosdk#794)
Changes conforming to 0chain/gosdk#794
Changes
misc.go
for improved rounding off when converting floats to intsFixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):