Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm expose: stakepool funcs #845

Merged
merged 12 commits into from
Mar 15, 2023
Merged

wasm expose: stakepool funcs #845

merged 12 commits into from
Mar 15, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Mar 12, 2023 •
edited
Loading

Version

  • Ensure to run make getrev to update gosdk version info.

Changes

exposed

  • lockStakePool
  • unlockStakePool
  • getstakePoolInfo

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@boddumanohar boddumanohar changed the title wasm expose: lockStakePool & unlockStakePool wasm expose: stakepool funcs Mar 13, 2023
cnlangzi
cnlangzi suggested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small fixes

wasmsdk/allocation.go Outdated Show resolved Hide resolved
@boddumanohar boddumanohar requested a review from cnlangzi March 14, 2023 08:08
cnlangzi
cnlangzi approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit fe715cc into staging Mar 15, 2023
@cnlangzi cnlangzi deleted the expose-sp-lock branch March 15, 2023 02:52
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests kill_shudown_config
gosdk staging
zboxcli staging
zwalletcli staging
0chain blobber_kill_shutdown
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boddumanohar @service-0chain @cnlangzi @aaryankotharii