Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/revert to readcounter #249

Merged
merged 7 commits into from
Apr 23, 2022
Merged

Fix/revert to readcounter #249

merged 7 commits into from
Apr 23, 2022

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Apr 23, 2022

This PR fixes some tests as it was fixed by associated PRs in blobber 0chain/blobber#632

@lpoli lpoli mentioned this pull request Apr 23, 2022
Merged
3 tasks
@lpoli lpoli requested a review from Kishan-Dhakan April 23, 2022 07:30
Kishan-Dhakan
Kishan-Dhakan suggested changes Apr 23, 2022
View reviewed changes
tests/cli_tests/zboxcli_transfer_allocation_test.go Outdated Show resolved Hide resolved
tests/cli_tests/zboxcli_download_test.go Show resolved Hide resolved
tests/cli_tests/zboxcli_download_test.go Outdated Show resolved Hide resolved
tests/cli_tests/zboxcli_download_test.go Outdated Show resolved Hide resolved
lpoli added 2 commits April 23, 2022 14:09
@lpoli
Remove commented code
17091cf
@lpoli
Add assertion on output
f25bc7b 
Set retry to false for failing download
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/revert-to-readcounter
gosdk NOT OVERRIDDEN
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/revert-to-readcounter
gosdk NOT OVERRIDDEN
zboxcli fix/revert-to-readcounter
zwalletcli staging
0chain fix/revert-to-readcounter
blobber fix/revert-to-readcounter
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@lpoli lpoli requested a review from Kishan-Dhakan April 23, 2022 15:24
@lpoli lpoli merged commit 7e386a0 into master Apr 23, 2022
@lpoli lpoli deleted the fix/revert-to-readcounter branch April 24, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Awaiting requested review from Kishan-Dhakan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpoli @service-0chain @Kishan-Dhakan