Feature/add coverage

tests/api_tests/create_allocation_test.go

@@ -28,6 +28,7 @@ func TestCreateAllocation(t *testing.T) {
 }
 
 func createAllocation(t *testing.T, wallet *model.Wallet, keyPair model.KeyPair, blobberRequirements model.BlobberRequirements) (*model.TransactionResponse, *model.Confirmation) {
+	t.Logf("Creating allocation...")
 	txnDataString, err := json.Marshal(model.SmartContractTxnData{Name: "new_allocation_request", InputArgs: blobberRequirements})
 	require.Nil(t, err)
 	allocationRequest := model.Transaction{
@@ -61,6 +62,7 @@ func getAllocation(t *testing.T, allocationId string) *model.Allocation {
 }
 
 func getAllocationWithoutAssertion(t *testing.T, allocationId string) (*model.Allocation, *resty.Response, error) { //nolint
+	t.Logf("Retrieving allocation...")
 	balance, httpResponse, err := v1ScrestAllocation(t, allocationId)
 	return balance, httpResponse, err
 }

tests/api_tests/execute_faucet_test.go

@@ -59,6 +59,7 @@ func confirmTransaction(t *testing.T, wallet *model.Wallet, sentTransaction mode
 }
 
 func confirmTransactionWithoutAssertion(t *testing.T, hash string, maxPollDuration time.Duration) (*model.Confirmation, *resty.Response, error) { //nolint
+	t.Logf("Confirming transaction...")
 	confirmation, httpResponse, err := v1TransactionGetConfirmation(t, hash)
 
 	startPollTime := time.Now()
@@ -81,11 +82,13 @@ func getBalance(t *testing.T, clientId string) *model.Balance {
 }
 
 func getBalanceWithoutAssertion(t *testing.T, clientId string) (*model.Balance, *resty.Response, error) { //nolint
+	t.Logf("Getting balance...")
 	balance, httpResponse, err := v1ClientGetBalance(t, clientId)
 	return balance, httpResponse, err
 }
 
 func executeFaucet(t *testing.T, wallet *model.Wallet, keyPair model.KeyPair) *model.TransactionResponse {
+	t.Logf("Executing faucet...")
 	txnDataString, err := json.Marshal(model.SmartContractTxnData{Name: "pour"})
 	require.Nil(t, err)
 	faucetRequest := model.Transaction{

tests/api_tests/get_blobbers_for_new_allocation_test.go

@@ -16,15 +16,18 @@ func TestGetBlobbersForNewAllocation(t *testing.T) {
 		t.Parallel()
 		registeredWallet, keyPair := registerWallet(t)
 		blobbers, blobberRequirements := getBlobbersMatchingRequirements(t, registeredWallet, keyPair, 2147483648, 2, 2, 3600000000000, time.Minute*2)
-		println("", blobbers)
-		json.Marshal(blobberRequirements)
+		require.NotNil(t, blobbers)
+		require.Greater(t, len(*blobbers), 3)
+		require.NotNil(t, blobberRequirements)
 	})
 
 	t.Run("Alloc blobbers API call should fail gracefully given valid request", func(t *testing.T) {
 		t.Parallel()
 		t.Skip("FIXME: lack of field validation leads to error")
-		blobbers, _, _ := v1ScrestAllocBlobbers(t, "{}")
-		println(blobbers)
+		blobbers, response, err := v1ScrestAllocBlobbers(t, "{}")
+		require.NotNil(t, blobbers)
+		require.NotNil(t, response)
+		require.NotNil(t, err)
 	})
 
 }
@@ -40,6 +43,7 @@ func getBlobbersMatchingRequirements(t *testing.T, wallet *model.Wallet, keyPair
 }
 
 func getBlobbersMatchingRequirementsWithoutAssertion(t *testing.T, wallet *model.Wallet, keyPair model.KeyPair, size int64, dataShards int64, parityShards int64, maxChallengeCompletionTime int64, expiresIn time.Duration) (*[]string, model.BlobberRequirements, *resty.Response, error) { //nolint
+	t.Logf("Get blobbers for allocation...")
 	blobberRequirements := model.BlobberRequirements{
 		Size:                       size,
 		DataShards:                 dataShards,

tests/api_tests/register_wallet_test.go

@@ -56,6 +56,7 @@ func registerWalletForMnemonic(t *testing.T, mnemonic string) (*model.Wallet, mo
 }
 
 func registerWalletForMnemonicWithoutAssertion(t *testing.T, mnemonic string) (*model.Wallet, model.KeyPair, *resty.Response, error) { //nolint
+	t.Logf("Registering wallet...")
 	keyPair := crypto.GenerateKeys(t, mnemonic)
 	publicKeyBytes, _ := hex.DecodeString(keyPair.PublicKey.SerializeToHexStr())
 	clientId := crypto.Sha3256(publicKeyBytes)

tests/cli_tests/flaky___broken_scenarios_test.go

@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"os"
-	"path"
 	"path/filepath"
 	"regexp"
 	"strconv"
@@ -527,29 +526,6 @@ func Test___FlakyBrokenScenarios(t *testing.T) {
 		require.InEpsilon(t, totalChangeInWritePool, intToZCN(challengePool.Balance), epsilon, "expected challenge pool balance to match deducted amount from write pool [%v] but balance was actually [%v]", totalChangeInWritePool, intToZCN(challengePool.Balance))
 	})
 
-	t.Run("delete existing file in root directory with commit should work", func(t *testing.T) {
-		t.Parallel()
-
-		allocationID := setupAllocation(t, configPath)
-		defer createAllocationTestTeardown(t, allocationID)
-
-		remotepath := "/"
-		filesize := int64(1 * KB)
-		filename := generateFileAndUpload(t, allocationID, remotepath, filesize)
-		fname := filepath.Base(filename)
-		remoteFilePath := path.Join(remotepath, fname)
-
-		output, err := deleteFile(t, escapedTestName(t), createParams(map[string]interface{}{
-			"allocation": allocationID,
-			"remotepath": remoteFilePath,
-			"commit":     true,
-		}), true)
-
-		// FIXME: error in deleting file with commit
-		require.NotNil(t, err, strings.Join(output, "\n"))
-		require.Len(t, output, 1)
-	})
-
 	// FIXME: Commented out because these cases hang the broken test suite till timeout
 
 	// FIXME: add param validation