Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner block rewards test #491

Merged
merged 86 commits into from
Jan 30, 2023
Merged

Miner block rewards test #491

merged 86 commits into from
Jan 30, 2023

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Dec 8, 2022

Needs:
https://github.com/0chain/0chain/pull/1870/files for new rewards table.
0chain/actions#87 adds debug = false config entry needed for tests.

@Sriep Sriep marked this pull request as draft December 8, 2022 12:10
@Sriep Sriep marked this pull request as ready for review December 9, 2022 10:05
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed, but great work as usual @Sriep

internal/cli/util/api_get_list.go Outdated Show resolved Hide resolved
internal/cli/util/history.go Show resolved Hide resolved
internal/cli/util/history.go Show resolved Hide resolved
tests/api_tests/config/api_tests_config.yaml Outdated Show resolved Hide resolved
tests/cli_tests/config/cli_tests_config.yaml Outdated Show resolved Hide resolved
tests/cli_tests/miner_block_rewards_test.go Outdated Show resolved Hide resolved
tests/cli_tests/zwalletcli_mn_pool_info_test.go Outdated Show resolved Hide resolved
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests block_rewards
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix_testnodestat
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sriep Sriep merged commit 9d324a8 into master Jan 30, 2023
@Sriep Sriep deleted the block_rewards branch January 30, 2023 15:05
boddumanohar pushed a commit that referenced this pull request Feb 5, 2023
peterlimg pushed a commit that referenced this pull request Feb 15, 2023
* clean up collaborator feature

* cleanup  more instances of addCollaborator

* clean up: un-used functions

* cleanup: getReadPoolUpdate

* fix lint errors

* cleanup file: zboxcli_collaborator_test.go

* Remove system test which tests creation of allocation with name (#526)

* Remove system test which tests creation of allocation with name

* Remove tests that verifies update allocation name

* Miner block rewards test (#491)

* Remove no_username (#528)

* remove no_username

* lint fix

* fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.MakeSCRestAPICall (#514)

* fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.MakeSCRestAPICall

* fix(upload): improved error message on os.Open

* System test 508 - 0Box Allocation system tests (#519)

* created list and create allocation method for 0box allocation test

* modified allocation struct

* refactor

* remove unused import

* completed the issue

* removed lint issues

* Fix panic in 0box tests (#507)

Add nil check in 0box tests

* Skip tests due to slow goerli

* Worked upon review provided

* created get allocation method

* added one ore test case

* rebasing

* added testcases for get allocation

* added few more testcases

* worked upon review comment

* corrected spelling which was causing lint issues in system tests

* worked upon review and added update allocation

* ready to merge

* ready to merge

---------

Co-authored-by: Kishan-Dhakan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Kishan Dhakan <[email protected]>

* fix lint issues

---------

Co-authored-by: Kishan Dhakan <[email protected]>
Co-authored-by: Lz <[email protected]>
Co-authored-by: Areeb Usmani <[email protected]>
Co-authored-by: Piers Shepperson <[email protected]>
Co-authored-by: shalinikum <[email protected]>
Co-authored-by: Kishan-Dhakan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miner and sharder collect rewards system tests.
4 participants