-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miner block rewards test #491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/cli_tests/zwalletcli_miner_stake_test.go
Kishan-Dhakan
suggested changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed, but great work as usual @Sriep
Manual system tests [failure] with the following config
|
Kishan-Dhakan
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
boddumanohar
pushed a commit
that referenced
this pull request
Feb 5, 2023
peterlimg
pushed a commit
that referenced
this pull request
Feb 15, 2023
* clean up collaborator feature * cleanup more instances of addCollaborator * clean up: un-used functions * cleanup: getReadPoolUpdate * fix lint errors * cleanup file: zboxcli_collaborator_test.go * Remove system test which tests creation of allocation with name (#526) * Remove system test which tests creation of allocation with name * Remove tests that verifies update allocation name * Miner block rewards test (#491) * Remove no_username (#528) * remove no_username * lint fix * fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.MakeSCRestAPICall (#514) * fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.MakeSCRestAPICall * fix(upload): improved error message on os.Open * System test 508 - 0Box Allocation system tests (#519) * created list and create allocation method for 0box allocation test * modified allocation struct * refactor * remove unused import * completed the issue * removed lint issues * Fix panic in 0box tests (#507) Add nil check in 0box tests * Skip tests due to slow goerli * Worked upon review provided * created get allocation method * added one ore test case * rebasing * added testcases for get allocation * added few more testcases * worked upon review comment * corrected spelling which was causing lint issues in system tests * worked upon review and added update allocation * ready to merge * ready to merge --------- Co-authored-by: Kishan-Dhakan <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Kishan Dhakan <[email protected]> * fix lint issues --------- Co-authored-by: Kishan Dhakan <[email protected]> Co-authored-by: Lz <[email protected]> Co-authored-by: Areeb Usmani <[email protected]> Co-authored-by: Piers Shepperson <[email protected]> Co-authored-by: shalinikum <[email protected]> Co-authored-by: Kishan-Dhakan <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs:
https://github.com/0chain/0chain/pull/1870/files for new rewards table.
0chain/actions#87 adds
debug = false
config entry needed for tests.