Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New stake pool fields, updated goSDK #176

Merged
merged 11 commits into from
Mar 10, 2022
Merged

New stake pool fields, updated goSDK #176

merged 11 commits into from
Mar 10, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Feb 22, 2022 •
edited by ssardana96
Loading

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master BEFORE merging this PR

Associated PRs (Link as appropriate):
0chain/gosdk#388 0chain/0chain#1013

This was referenced Feb 22, 2022
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk sp-info
zboxcli sp-info
zwalletcli staging
0chain edb-stakepool
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Sriep Sriep mentioned this pull request Feb 23, 2022
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests sp-info-changes
gosdk sp-info
zboxcli sp-info
zwalletcli staging
0chain edb-stakepool
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests sp-info-changes
gosdk sp-info
zboxcli sp-info
zwalletcli staging
0chain edb-stakepool
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Sriep Sriep merged commit 4e3a97e into staging Mar 10, 2022
@Sriep Sriep deleted the sp-info branch March 10, 2022 15:23
@Kishan-Dhakan Kishan-Dhakan mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssardana96 ssardana96 ssardana96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sriep @service-0chain @ssardana96