feature/99-statuscode-204-for-file-not-found #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2022
cnlangzi
changed the title
princeparmar
changed the title
cnlangzi
changed the title
Signed-off-by: Pradip Parmar <[email protected]>
princeparmar
force-pushed
the
feature/99-statuscode-204-for-file-not-found
branch
from
c5c6174 to
9944993
Compare
|
Manual system tests [failure] with the following config
|
|
Manual system tests [success] with the following config
|
cnlangzi
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pradip Parmar [email protected]
Tasks to complete before merging PR:
Ensure system tests are passing. If not Run them manually to check for any regressions 📋
Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
Merge your system tests PR to master BEFORE merging this PR
Issue: It is better to return 204 if object is not found in blobber #99
Associated PRs (Link as appropriate):