Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(upload): integrate WriteMarkerMutex on ChunkUpload #184

Merged
merged 7 commits into from
Mar 6, 2022
Merged

feat(upload): integrate WriteMarkerMutex on ChunkUpload #184

merged 7 commits into from
Mar 6, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Mar 2, 2022 •
edited
Loading

Changes

  • integrate WriteMarkerMutex on ChunkUpload

Fixes

Test

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi requested review from dabasov and peterlimg March 2, 2022 02:47
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/integrate_wmlock_on_upload
zboxcli feat/integrate_wmlock_on_upload
zwalletcli staging
0chain staging
blobber feat/ref_load_root_hash_node
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/integrate_wmlock_on_upload
zboxcli feat/integrate_wmlock_on_upload
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

This was referenced Mar 3, 2022
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/integrate_wmlock_on_upload
zboxcli feat/integrate_wmlock_on_upload
zwalletcli staging
0chain staging
blobber feat/integrate_wmlock_on_upload
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peterlimg
peterlimg approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/integrate_wmlock_on_upload
zboxcli feat/integrate_wmlock_on_upload
zwalletcli staging
0chain staging
blobber feat/integrate_wmlock_on_upload
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/integrate_wmlock_on_upload
zboxcli feat/integrate_wmlock_on_upload
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit 0600f34 into staging Mar 6, 2022
@cnlangzi cnlangzi deleted the feat/integrate_wmlock_on_upload branch March 6, 2022 07:20
@cnlangzi cnlangzi mentioned this pull request Mar 6, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnlangzi @service-0chain @peterlimg