Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/524 #192

Merged
merged 14 commits into from
Apr 4, 2022
Merged

issue/524 #192

merged 14 commits into from
Apr 4, 2022

Conversation

abouroumine
Copy link
Contributor

@abouroumine abouroumine commented Mar 17, 2022

zbox required for blobber issue/524.

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

zbox required for blobber issue/524.
This was referenced Mar 17, 2022
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

cleaned for review.
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk blobber/issue-524
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk blobber/issue-524
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests blobber/issue-524
gosdk NOT OVERRIDDEN
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests blobber/issue-524
gosdk blobber/issue-524
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests blobber/issue-524
gosdk blobber/issue-524
zboxcli blobber/issue-524
zwalletcli staging
0chain staging
blobber issue/524
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abouroumine abouroumine merged commit 5f48912 into staging Apr 4, 2022
@Sriep Sriep deleted the blobber/issue-524 branch August 25, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants