Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/batch chunks upload #200

Merged
merged 7 commits into from
Mar 26, 2022
Merged

Feat/batch chunks upload #200

merged 7 commits into from
Mar 26, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Mar 25, 2022 •
edited
Loading

Changes

  • added chunks batch upload featrue

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi marked this pull request as draft March 25, 2022 03:26
This was referenced Mar 25, 2022
Merged
Merged
@cnlangzi cnlangzi requested a review from peterlimg March 25, 2022 06:24
@cnlangzi cnlangzi marked this pull request as ready for review March 25, 2022 06:24
@0chain 0chain deleted a comment from service-0chain Mar 25, 2022
@0chain 0chain deleted a comment from service-0chain Mar 25, 2022
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/batch_chunks_upload
zboxcli feat/batch_chunks_upload
zwalletcli staging
0chain staging
blobber feat/batch_chunks_upload
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 5aa1c2f into staging Mar 26, 2022
@cnlangzi cnlangzi deleted the feat/batch_chunks_upload branch March 26, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnlangzi @service-0chain @peterlimg