Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #202 added total stake #203

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Fix #202 added total stake #203

merged 6 commits into from
Sep 29, 2022

Conversation

samtholiya
Copy link
Contributor

@samtholiya samtholiya commented Mar 25, 2022 •
edited
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@samtholiya samtholiya linked an issue Mar 25, 2022 that may be closed by this pull request
ZBox should be able to display total stakes #202
Closed
This was referenced Mar 25, 2022
Merged
Closed
@samtholiya samtholiya mentioned this pull request Apr 4, 2022
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk totalstakeBlobber
zboxcli displaytotalstake
zwalletcli staging
0chain totalstakeblobber
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@0chain 0chain deleted a comment from service-0chain Apr 4, 2022
@0chain 0chain deleted a comment from service-0chain Apr 4, 2022
@0chain 0chain deleted a comment from service-0chain Apr 4, 2022
cnlangzi and others added 2 commits June 17, 2022 10:38
dabasov
dabasov approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk staging
zboxcli displaytotalstake
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped YES
system-tests master
gosdk staging
zboxcli displaytotalstake
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit c7869cf into staging Sep 29, 2022
@cnlangzi cnlangzi deleted the displaytotalstake branch September 29, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep approved these changes

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZBox should be able to display total stakes
5 participants
@samtholiya @service-0chain @dabasov @Sriep @cnlangzi