Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gosdk to staging #204

Merged
merged 1 commit into from
Mar 27, 2022
Merged

update gosdk to staging #204

merged 1 commit into from
Mar 27, 2022

Conversation

Kishan-Dhakan
Copy link
Contributor

A brief description of the changes in this PR:
Updates gosdk to staging

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@Kishan-Dhakan Kishan-Dhakan requested a review from dabasov March 27, 2022 20:41
dabasov
dabasov approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kishan-Dhakan Kishan-Dhakan merged commit 39bb6d8 into staging Mar 27, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the feat/update-gosdk branch March 27, 2022 20:42
peterlimg pushed a commit that referenced this pull request Mar 28, 2022
@Kishan-Dhakan @peterlimg
Merge pull request #204 from 0chain/feat/update-gosdk
a621d9a 
update gosdk to staging
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk staging
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewartie4 stewartie4 stewartie4 approved these changes

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kishan-Dhakan @service-0chain @dabasov @stewartie4