Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gosdk to add state_changes_count to block #205

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Update gosdk to add state_changes_count to block #205

merged 2 commits into from
Apr 2, 2022

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented Mar 28, 2022 •
edited
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Mar 28, 2022
Merged
Merged
Merged
@peterlimg peterlimg force-pushed the fix/add-state-changes-count-block branch from 65cd543 to a621d9a Compare March 28, 2022 00:36
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/add-state-changes-count-block
zwalletcli fix/add-state-changes-count-block
0chain fix/garbage-partial-state
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg force-pushed the fix/add-state-changes-count-block branch from a621d9a to f00ba63 Compare March 28, 2022 23:51
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/add-state-changes-count-block
zwalletcli fix/add-state-changes-count-block
0chain fix/garbage-partial-state
blobber fix/state-changes-count-block
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/add-state-changes-count-block
zwalletcli fix/add-state-changes-count-block
0chain fix/garbage-partial-state
blobber fix/state-changes-count-block
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

dabasov
dabasov approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg peterlimg force-pushed the fix/add-state-changes-count-block branch from db9d1b3 to 156e0be Compare April 2, 2022 00:28
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/add-state-changes-count-to-block
zboxcli fix/add-state-changes-count-block
zwalletcli fix/add-state-changes-count-block
0chain staging
blobber fix/state-changes-count-block
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli fix/add-state-changes-count-block
zwalletcli fix/add-state-changes-count-block
0chain staging
blobber fix/state-changes-count-block
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit 4b5fd44 into staging Apr 2, 2022
@Sriep Sriep deleted the fix/add-state-changes-count-block branch August 25, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterlimg @service-0chain @dabasov