Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gomod): upgrade go with v1.18 #218

Merged
merged 2 commits into from
Apr 21, 2022
Merged

fix(gomod): upgrade go with v1.18 #218

merged 2 commits into from
Apr 21, 2022

Conversation

Rizary
Copy link
Contributor

@Rizary Rizary commented Apr 21, 2022

A brief description of the changes in this PR:

update go mod to 1.18
Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@Rizary Rizary requested a review from cnlangzi April 21, 2022 10:29
@cnlangzi cnlangzi mentioned this pull request Apr 21, 2022
Merged
3 tasks
cnlangzi
cnlangzi reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit c3907dc into staging Apr 21, 2022
@cnlangzi cnlangzi deleted the fix/go18 branch April 21, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rizary @cnlangzi