Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gosdk updated #219

Merged
merged 1 commit into from
Apr 22, 2022
Merged

gosdk updated #219

merged 1 commit into from
Apr 22, 2022

Conversation

Dmdv
Copy link
Contributor

@Dmdv Dmdv commented Apr 22, 2022

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@Dmdv Dmdv requested a review from dabasov April 22, 2022 04:54
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk refactor_authorizer
zboxcli upgraded_gosdk
zwalletcli sdk_update
0chain refactor_authorizer
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Dmdv Dmdv requested review from peterlimg, Sriep and cnlangzi April 22, 2022 07:47
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add all related PR links on Associated PRs (Link as appropriate) next time. it is easier for reviewer to check if gosdk is imported properly. thanks.

@cnlangzi cnlangzi merged commit 47f1d4e into staging Apr 22, 2022
@cnlangzi cnlangzi deleted the upgraded_gosdk branch April 22, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants