Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Makefile): improve gomod-download #220

Merged
merged 1 commit into from
Apr 22, 2022
Merged

fix(Makefile): improve gomod-download #220

merged 1 commit into from
Apr 22, 2022

Conversation

cnlangzi
Copy link
Contributor

Fixes

  • improved make gomod-download with go mod tidy

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi requested a review from Kishan-Dhakan April 22, 2022 08:37
dabasov
dabasov approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 18226d1 into staging Apr 22, 2022
@cnlangzi cnlangzi deleted the fix/setup_go branch April 22, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@Kishan-Dhakan Kishan-Dhakan Awaiting requested review from Kishan-Dhakan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnlangzi @dabasov