Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alloc): added name field #221

Merged
merged 5 commits into from
Apr 25, 2022
Merged

feat(alloc): added name field #221

merged 5 commits into from
Apr 25, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Apr 22, 2022 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Apr 22, 2022
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk feat/add_name_on_alloc
zboxcli feat/add_name_on_alloc
zwalletcli staging
0chain feat/add_name_on_alloc
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg requested changes Apr 23, 2022
View reviewed changes
cmd/updateallocation.go Outdated
@@ -128,4 +131,7 @@ func init() {

updateAllocationCmd.MarkFlagRequired("allocation")

updateAllocationCmd.Flags().StringVarP(&updateAllocationName, "name", "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better not use the global variable here, do it the same as other flags.

@cnlangzi cnlangzi mentioned this pull request Apr 25, 2022
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests feat/add_name_on_alloc
gosdk feat/add_name_on_alloc
zboxcli feat/add_name_on_alloc
zwalletcli staging
0chain feat/add_name_on_alloc
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests feat/add_name_on_alloc
gosdk feat/add_name_on_alloc
zboxcli feat/add_name_on_alloc
zwalletcli staging
0chain feat/add_name_on_alloc
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit 98dad22 into staging Apr 25, 2022
@cnlangzi cnlangzi deleted the feat/add_name_on_alloc branch April 25, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnlangzi @service-0chain @peterlimg