Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transaction nonce #230

Merged
merged 39 commits into from
May 9, 2022
Merged

Feature/transaction nonce #230

merged 39 commits into from
May 9, 2022

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented May 7, 2022

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@dabasov dabasov requested review from cnlangzi and peterlimg May 7, 2022 22:05
cmd/root.go Show resolved Hide resolved
@peterlimg
Copy link
Member

@dabasov there too many commits for merging code from staging, the commit history will be clearer if we rebase and merge those commits from staging.

@dabasov
Copy link
Member Author

dabasov commented May 8, 2022

Can we do it right in the github merging pull request? there is squash commits feature, think it can work in this case

@peterlimg
Copy link
Member

yes, sure, we can do it in github

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests feature/transaction-nonce
gosdk NOT OVERRIDDEN
zboxcli feature/transaction-nonce
zwalletcli feature/transaction-nonce
0chain feature/transaction_nonce
blobber feature/transaction-nonce
authorizer staging
0box feature/transaction-nonce
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov merged commit 8fdb3cf into staging May 9, 2022
@cnlangzi cnlangzi deleted the feature/transaction-nonce branch February 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants