Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated gosdk version #242

Merged
merged 2 commits into from
May 29, 2022
Merged

updated gosdk version #242

merged 2 commits into from
May 29, 2022

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented May 28, 2022

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@dabasov dabasov requested a review from Sriep May 28, 2022 14:57
@dabasov dabasov self-assigned this May 28, 2022
@dabasov
Merge branch 'staging' into fix/get_config
7fe388d 
# Conflicts:
#	go.mod
#	go.sum
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/broken_owner_test
gosdk staging
zboxcli fix/get_config
zwalletcli fix/get_config
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/broken_owner_test
gosdk staging
zboxcli fix/get_config
zwalletcli fix/get_config
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 633d99c into staging May 29, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the fix/get_config branch May 29, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewartie4 stewartie4 stewartie4 approved these changes

@Sriep Sriep Awaiting requested review from Sriep

@peterlimg peterlimg Awaiting requested review from peterlimg

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

@Kishan-Dhakan Kishan-Dhakan Awaiting requested review from Kishan-Dhakan

Assignees

@dabasov dabasov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dabasov @service-0chain @stewartie4 @Kishan-Dhakan