Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zcncore): fixed panicking issue on logging #243

Merged
merged 1 commit into from
May 30, 2022
Merged

fix(zcncore): fixed panicking issue on logging #243

merged 1 commit into from
May 30, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented May 30, 2022 •
edited
Loading

Changes

Fixes

  • fixed panicking issue on logging

Tests

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi requested a review from Kishan-Dhakan May 30, 2022 08:48
This was referenced May 30, 2022
Merged
Merged
Merged
@cnlangzi cnlangzi requested a review from peterlimg May 30, 2022 09:35
Kishan-Dhakan
Kishan-Dhakan approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 67b04cc into staging May 30, 2022
@cnlangzi cnlangzi deleted the fix/panicking_on_fromall branch May 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnlangzi @Kishan-Dhakan