Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access total-stored-data #245

Merged
merged 10 commits into from
Jun 3, 2022
Merged

Access total-stored-data #245

merged 10 commits into from
Jun 3, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Jun 1, 2022 •
edited
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@Sriep Sriep changed the title Aaccess Total stored data Access total-stored-data Jun 1, 2022
This was referenced Jun 1, 2022
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk total-stored-data
zboxcli total_stored_data
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg requested changes Jun 3, 2022
View reviewed changes
cmd/total-stored-data.go
doJSON, _ := cmd.Flags().GetBool("json")
var info = make(map[string]int64)
if info, err = sdk.GetTotalStoredData(); err != nil {
log.Fatalf("Failed to get total stored data: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return if err != nil

peterlimg
peterlimg approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sriep Sriep merged commit ad52cdc into staging Jun 3, 2022
@Sriep Sriep deleted the total_stored_data branch June 3, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sriep @service-0chain @peterlimg