Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New single balance ReadPool #256

Merged
merged 1 commit into from
Jun 13, 2022
Merged

New single balance ReadPool #256

merged 1 commit into from
Jun 13, 2022

Conversation

iamrz1
Copy link
Contributor

@iamrz1 iamrz1 commented Jun 12, 2022

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests single-balance-readpool
gosdk NOT OVERRIDDEN
zboxcli single-balance-readpool
zwalletcli staging
0chain single-balance-readpool
blobber single-balance-readpool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests single-balance-readpool
gosdk NOT OVERRIDDEN
zboxcli single-balance-readpool
zwalletcli staging
0chain single-balance-readpool
blobber single-balance-readpool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit a13bdba into staging Jun 13, 2022
@cnlangzi cnlangzi deleted the single-balance-readpool branch February 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants