Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove user write pool #258

Merged
merged 27 commits into from
Jul 26, 2022
Merged

Remove user write pool #258

merged 27 commits into from
Jul 26, 2022

Conversation

Sriep
Copy link
Contributor

@Sriep Sriep commented Jun 13, 2022 •
edited
Loading

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

This was referenced Jun 13, 2022
Closed
Merged
@Sriep Sriep marked this pull request as draft June 13, 2022 14:02
@Sriep Sriep mentioned this pull request Jun 20, 2022
Merged
3 tasks
@Sriep Sriep mentioned this pull request Jun 21, 2022
Closed
3 tasks
@Sriep Sriep marked this pull request as ready for review June 22, 2022 13:48
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk remove_write_pools
zboxcli remove_write_pool
zwalletcli staging
0chain remove_write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan mentioned this pull request Jun 27, 2022
Merged
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests remove/writepool
gosdk remove_write_pools
zboxcli remove_write_pool
zwalletcli staging
0chain remove_write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Sriep Sriep mentioned this pull request Jul 5, 2022
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests remove/writepool
gosdk remove_write_pools
zboxcli remove_write_pool
zwalletcli staging
0chain write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests remove/writepool
gosdk remove_write_pools
zboxcli remove_write_pool
zwalletcli staging
0chain write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests remove/writepool
gosdk remove_write_pools
zboxcli remove_write_pool
zwalletcli staging
0chain remove_write_pool
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk remove_write_pools
zboxcli remove_write_pool
zwalletcli staging
0chain write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests remove/writepool
gosdk NOT OVERRIDDEN
zboxcli remove_write_pool
zwalletcli staging
0chain write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests remove/writepool
gosdk NOT OVERRIDDEN
zboxcli remove_write_pool
zwalletcli staging
0chain write_pools
blobber remove_write_pools
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk staging
zboxcli remove_write_pool
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit e240ba0 into staging Jul 26, 2022
@Sriep Sriep deleted the remove_write_pool branch August 25, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssardana08 ssardana08 ssardana08 approved these changes

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sriep @service-0chain @peterlimg @ssardana08 @dabasov @cnlangzi @Kishan-Dhakan