Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List file support #267

Merged
merged 10 commits into from
Jun 22, 2022
Merged

List file support #267

merged 10 commits into from
Jun 22, 2022

Conversation

avanaur
Copy link
Contributor

@avanaur avanaur commented Jun 18, 2022

A brief description of the changes in this PR:

Support listing of file and not just directory on zbox list

Resolves 0chain/blobber#699

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@avanaur avanaur mentioned this pull request Jun 18, 2022
3 tasks
@avanaur avanaur marked this pull request as ready for review June 18, 2022 04:43
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests feature/list-file
gosdk staging
zboxcli feature/list-file
zwalletcli staging
0chain staging
blobber feature/list-file
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests feature/list-file
gosdk staging
zboxcli feature/list-file
zwalletcli staging
0chain staging
blobber feature/list-file
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi requested a review from peterlimg June 20, 2022 02:10
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk staging
zboxcli feature/list-file
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit c597a67 into staging Jun 22, 2022
@cnlangzi cnlangzi deleted the feature/list-file branch February 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List endpoint only works on directories
3 participants