Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update provider enum to start from 1 #268

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Update provider enum to start from 1 #268

merged 1 commit into from
Jun 22, 2022

Conversation

peterlimg
Copy link
Member

Fixes:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

@peterlimg peterlimg mentioned this pull request Jun 19, 2022
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk NOT OVERRIDDEN
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk fix/getUsersPool
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk fix/getUsersPool
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

dabasov
dabasov approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/getUsersPool
gosdk NOT OVERRIDDEN
zboxcli fix/getUsersPool
zwalletcli fix/getUsersPool
0chain fix/getUserPools
blobber fix/getUsersPool
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit 8dc89bf into staging Jun 22, 2022
@cnlangzi cnlangzi deleted the fix/getUsersPool branch February 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterlimg @service-0chain @dabasov