Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client ID as stake pool id #291

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Use client ID as stake pool id #291

merged 5 commits into from
Sep 20, 2022

Conversation

peterlimg
Copy link
Member

@peterlimg peterlimg commented Aug 26, 2022

A brief description of the changes in this PR:

Changes

  • Update gosdk and remove pool_id param

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests one-pool
gosdk NOT OVERRIDDEN
zboxcli one-pool
zwalletcli one-pool
0chain fix/state-hash-mismatch-3
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests one-pool
gosdk NOT OVERRIDDEN
zboxcli one-pool
zwalletcli one-pool
0chain fix/state-hash-mismatch-3
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests one-pool
gosdk NOT OVERRIDDEN
zboxcli one-pool
zwalletcli staging
0chain fix/state-hash-mismatch-3
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests one-pool
gosdk NOT OVERRIDDEN
zboxcli one-pool
zwalletcli one-pool
0chain fix/state-hash-mismatch-3
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests one-pool
gosdk one-pool
zboxcli one-pool
zwalletcli one-pool
0chain fix/state-hash-mismatch-3
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit 45bf89f into staging Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants