Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function to set and get config dir #305

Merged
merged 3 commits into from
Oct 17, 2022
Merged

add function to set and get config dir #305

merged 3 commits into from
Oct 17, 2022

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Sep 30, 2022 •
edited
Loading

A brief description of the changes in this PR:

Add functions to get and set configDir

fixes: #293

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

peterlimg
peterlimg approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 8d1267f into staging Oct 17, 2022
@cnlangzi cnlangzi deleted the configdir branch October 17, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@cnlangzi cnlangzi cnlangzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New allocation does not honour configDir when writing allocation.txt (possibly wider scope than this)
3 participants
@boddumanohar @cnlangzi @peterlimg