Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validator option in sp-info #309

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Added validator option in sp-info #309

merged 1 commit into from
Nov 5, 2022

Conversation

iamrz1
Copy link
Contributor

@iamrz1 iamrz1 commented Oct 9, 2022 •
edited
Loading

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli generic-sp-info
zwalletcli staging
0chain generic-sp-info
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@iamrz1 iamrz1 force-pushed the generic-sp-info branch 2 times, most recently from 6a0b09d to e1ae8f5 Compare October 26, 2022 13:58
dabasov
dabasov approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli generic-sp-info
zwalletcli staging
0chain generic-sp-info
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@iamrz1 iamrz1 force-pushed the generic-sp-info branch 2 times, most recently from bfb6580 to b10c97d Compare November 4, 2022 20:27
@iamrz1 iamrz1 mentioned this pull request Nov 5, 2022
Merged
3 tasks
@peterlimg
Copy link
Member

@iamrz1 please fix the conflicts

@iamrz1
Copy link
Contributor Author

iamrz1 commented Nov 5, 2022

Fixed conflicts. Please remember that this PR depends on changes to go-sdk in the linked PR.

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk staging
zboxcli generic-sp-info
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit 4f44aa7 into staging Nov 5, 2022
@peterlimg peterlimg deleted the generic-sp-info branch November 5, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating sp-info to make it generic
4 participants
@iamrz1 @service-0chain @peterlimg @dabasov