Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): throw error if allocation is invalid #310

Merged
merged 13 commits into from
Oct 26, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Oct 12, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests chore/upraded_deps
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/throws_error_on_list
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/throws_error_on_list
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/throws_error_on_list
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli fix/throws_error_on_list
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/throws_error_on_list
gosdk fix/throws_error_on_list
zboxcli fix/throws_error_on_list
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit 5885c20 into staging Oct 26, 2022
@cnlangzi cnlangzi deleted the fix/throws_error_on_list branch October 26, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing a file in another allocation does not fail but returns no output
3 participants