Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): exported lookup_hash and encrypted_key in list result #325

Merged
merged 3 commits into from
Nov 21, 2022
Merged

fix(list): exported lookup_hash and encrypted_key in list result #325

merged 3 commits into from
Nov 21, 2022

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

  • exported lookup_hash and encrypted_key in list-all output

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi requested a review from peterlimg November 17, 2022 07:02
@cnlangzi cnlangzi mentioned this pull request Nov 17, 2022
Merged
3 tasks
dabasov
dabasov approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/extend_list_all
zboxcli fix/extend_list_all
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit cbb30c5 into staging Nov 21, 2022
@cnlangzi cnlangzi deleted the fix/extend_list_all branch November 21, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnlangzi @service-0chain @dabasov