rp-info currency format

[SinanEkm]

A brief description of the changes in this PR:
Some changes have been made to the rp-info method. After the changes, rp-info method and --json option returning an output more like the ./zwallet getbalance method's output.

Tasks to complete before merging PR:

• Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

• 0chain:
• blobber:
• gosdk:
• system_test:
• zwalletcli:
• Other: ...

[Kishan-Dhakan]

@SinanEkm what's the status of this PR?

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	340-rp-info-value-returned-requires-consistent-zcn-currency-format
gosdk	staging
zboxcli	340-rp-info-value-returned-requires-consistent-zcn-currency-format
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	model.go-ReadPoolInfo-change
gosdk	staging
zboxcli	340-rp-info-value-returned-requires-consistent-zcn-currency-format
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	model.go-ReadPoolInfo-change
gosdk	staging
zboxcli	340-rp-info-value-returned-requires-consistent-zcn-currency-format
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[dabasov]

lgtm, is it the only pool where we have such a problem? does it work for stakepool and writepool correctly?

[SinanEkm]

lgtm, is it the only pool where we have such a problem? does it work for stakepool and writepool correctly?

do you mean formatting @dabasov ? If so, I checked sp-info command and it doesn't show USD value of the balance, too. I am not sure about writepool, is there wp-info command or any such thing that is equivalent to it?

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	TRUE
system-tests	model.go-ReadPoolInfo-change
gosdk	staging
zboxcli	340-rp-info-value-returned-requires-consistent-zcn-currency-format
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

[dabasov]

lgtm

[dabasov]

lgtm, is it the only pool where we have such a problem? does it work for stakepool and writepool correctly?

do you mean formatting @dabasov ? If so, I checked sp-info command and it doesn't show USD value of the balance, too. I am not sure about writepool, is there wp-info command or any such thing that is equivalent to it?

I mean this https://github.com/0chain/zboxcli/blob/23bc1d65cfbe6f33b51537c5c50a092b45a7b544/cmd/stakepool.go
should we have consistent output here?