Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added actual_size information to list-all cmd #351

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

SinanEkm
Copy link
Contributor

@SinanEkm SinanEkm commented Feb 9, 2023

A brief description of the changes in this PR:

Added actual_size information to list-all and list commands regarding: https://0chain.slack.com/archives/G013NS35YF4/p1675062843835069

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@SinanEkm SinanEkm marked this pull request as ready for review February 14, 2023 18:17
@Kishan-Dhakan
Copy link
Contributor

@SinanEkm please do a manual run with your custom ST branch

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests changes_zboxcli_351PR
gosdk staging
zboxcli modifying_list_all_command
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests changes_zboxcli_351PR
gosdk staging
zboxcli modifying_list_all_command
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests changes_zboxcli_351PR
gosdk staging
zboxcli modifying_list_all_command
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@Kishan-Dhakan Kishan-Dhakan merged commit 483e696 into staging Feb 20, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the modifying_list_all_command branch February 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants