Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted StakedAt to time.Time #352

Merged
merged 5 commits into from
Feb 15, 2023
Merged

converted StakedAt to time.Time #352

merged 5 commits into from
Feb 15, 2023

Conversation

pgrudra
Copy link
Contributor

@pgrudra pgrudra commented Feb 10, 2023

converted StakedAt to time.Time for readability of time

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain staked_at-attribute-for-DelegatePoolStat
blobber staging
authorizer staging
0box 727-staked_at-is-incorrect-in-zbox-sp-user-info
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain staked_at-attribute-for-DelegatePoolStat
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain staked_at-attribute-for-DelegatePoolStat
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@pgrudra pgrudra mentioned this pull request Feb 11, 2023
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain test_staked_at
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain test_staked_at
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 727-staked_at-is-incorrect-in-zbox-sp-user-info
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain staked_at-attribute-for-DelegatePoolStat
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg
Copy link
Member

@pgrudra please resolve the conflicts

@peterlimg peterlimg force-pushed the staked-at-for-stake-pool-datatype-change branch from 9a97d19 to 3647b57 Compare February 15, 2023 02:30
peterlimg
peterlimg approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk staging
zboxcli staked-at-for-stake-pool-datatype-change
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit 2d1ab78 into staging Feb 15, 2023
@peterlimg peterlimg deleted the staked-at-for-stake-pool-datatype-change branch February 15, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgrudra @service-0chain @peterlimg