Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed curator from zboxcli #372

Merged
merged 24 commits into from
Mar 11, 2023
Merged

removed curator from zboxcli #372

merged 24 commits into from
Mar 11, 2023

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Mar 4, 2023 •
edited
Loading

Removed curator functionality from zboxcli .

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

dabasov and others added 14 commits September 29, 2022 18:00
@dabasov
updated gosdk version
35214af
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
e181824 
# Conflicts:
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
0a8343f
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
8ac4d79
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
caff767
@areebusmani
Remove allocation name
d19fb05
@areebusmani
Remove allocation name
068d86b
@areebusmani
Update go sdk
dd0a4e3
@areebusmani
Merge branch 'staging' into areeb/allocname
1d1f67f
@areebusmani
Merge branch 'staging' into areeb/allocname
8b0d81d
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
d361795
@dabasov
Merge remote-tracking branch 'origin/areeb/allocname' into staging
a53e0ff 
# Conflicts:
#	cmd/newallocation.go
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
e16e00c 
# Conflicts:
#	go.mod
#	go.sum
@Hitenjain14
removed curator from zboxcli
93ff90e
This was referenced Mar 4, 2023
Merged
Merged
Merged
dabasov
dabasov approved these changes Mar 7, 2023
View reviewed changes
cmd/addcurator.go Outdated
@@ -1,55 +1 @@
package cmd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove file

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests rm_curator
gosdk NOT OVERRIDDEN
zboxcli rm_curator
zwalletcli staging
0chain rm-curator
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests rm_curator
gosdk NOT OVERRIDDEN
zboxcli rm_curator
zwalletcli staging
0chain rm-curator
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov
Copy link
Member

dabasov commented Mar 10, 2023

passed here https://github.com/0chain/0chain/actions/runs/4366536380/jobs/7682602847

@dabasov
Merge branch 'staging' into rm_curator
ab7d0dd 
# Conflicts:
#	go.mod
#	go.sum
@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests master
gosdk staging
zboxcli rm_curator
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests rm_curator
gosdk rm_curator
zboxcli rm_curator
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests rm_curator
gosdk rm_curator
zboxcli rm_curator
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@peterlimg peterlimg merged commit e6d8015 into staging Mar 11, 2023
@peterlimg peterlimg deleted the rm_curator branch March 11, 2023 11:33
peterlimg added a commit that referenced this pull request Mar 11, 2023
@peterlimg
Merge branch 'staging' into chain-fee
74c1a2d 
* staging:
  removed curator from zboxcli (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hitenjain14 @service-0chain @dabasov @peterlimg @areebusmani